please clean up line for me

[falshdancer]

Hey there!
Im building a tween prototype and it works great, but the argument with the delete onEnterFrame is a bit sloppy. How can I write it using the var i in the for loop?

Cheers!

code:

---

MovieClip.prototype.tween = function(prop, finalValue, tweenSpeed) {

	var prop:Array;

	var finalVal:Array;

	var tweenSpeed:Number;

	var finished:Number;

	if (tweenSpeed == undefined) {

		tweenSpeed = .09;

	}

	this.onEnterFrame = function() {

		for (var i = 0; i<=(prop.length-1); i++) {

			//easeOut

			this[prop[i]] += (finalValue[i]-this[prop[i]])*tweenSpeed;

			//easeOutElastic

			if (parseInt(this[prop[i]]) == parseInt(finalValue[i])) {

				delete finalValue[i];

				if (finalValue[0] == undefined && finalValue[1] == undefined && finalValue[2] == undefined && finalValue[3] == undefined && finalValue[4] == undefined && finalValue[5] == undefined && finalValue[6] == undefined && finalValue[7]) {

					delete this.onEnterFrame;

				}

			}

			trace(this[prop[i]]+" / "+finalValue[i]);

		}

	};

};

//

onMouseDown = function () {

	box.tween(["_xscale", "_yscale"], [400, 500], .09);

};

---

[andreaskrenmair]

You could use the splice command for arrays. If it has reached its final value you could remove it from the array. Then check the length of the array!. If it is empty the script will delete the onEnterFrame:

MovieClip.prototype.tween = function(prop, finalValue, tweenSpeed) {
	var prop:Array;
	var finalVal:Array;
	var tweenSpeed:Number;
	var finished:Number;
	if (tweenSpeed == undefined) {
		tweenSpeed = .09;
	}
	this.onEnterFrame = function() {
		for (var i = 0; i<=(prop.length-1); i++) {
			//easeOut
			this[prop[i]] += (finalValue[i]-this[prop[i]])*tweenSpeed;
			//easeOutElastic
			if (parseInt(this[prop[i]]) == parseInt(finalValue[i])) {
finalValue.splice(i,1);
			}
			trace(this[prop[i]]+" / "+finalValue[i]);
		}
if(finalValue.length == 0){
delete this.onEnterFrame
}
	};
};

Edit: Sorry, I put the third if condition in the wrong line. This code should work now.

[falshdancer]

Yeah, great idea. works like a charm.(once I put the length argument in the this.onEnterframe )

Thanks

[joejoe2288]

try this dude, btw what is up haven't seen you forever:

for(i=0;i<=(prop.length-1);i++) {
if(finalValue[i] == undefined) {
if(i==(prop.length-1)) {
delete this.onEnterFrame
}else{
continue;
}
}else{
break;
}
}