A Flash Developer Resource Site

Results 1 to 4 of 4

Thread: Bad use of space, dumb way of doing things?

  1. #1
    Junior Member
    Join Date
    Jun 2008
    Posts
    8

    Bad use of space, dumb way of doing things?

    I'm using courina tweener....i feel like i'm doing things the long way\dumb way....anybody wanna provide insight?

    Code:
    stop();
          import caurina.transitions.*;
    	  import caurina.transitions.*;
    import caurina.transitions.properties.ColorShortcuts;
     ColorShortcuts.init();
    
     Tweener.addTween([s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, y :72.3});
    
    mc_home.rotation = 180
    mc_home.y -= 10 
    Tweener.addTween(mc_home, {_color:0xffffff, time:1});
    
    
    this
    
    mc_home.buttonMode = true;
    mc_why.buttonMode = true;
    mc_portfolio.buttonMode = true;
    mc_about.buttonMode = true;
    
    function startMovie(event:MouseEvent):void 
    
    {
    	{
    	if(mc_home.rotation > 1)
    	{
    		Tweener.addTween(event.target, {_color:0xffffff, rotation:180, time:.5, y:event.target.y-10});
    
    		Tweener.addTween(mc_home, {_color:0x000000, time:.5, rotation: 0, y:49});
    	}
    	else if(mc_why.rotation > 1)
    	{
    				Tweener.addTween(event.target, {_color:0xffffff, rotation:180, time:.5, y:event.target.y-10});
    
    				Tweener.addTween(mc_why, {_color:0x000000, time:.5, rotation: 0, y:49});
    	}
    	else if(mc_portfolio.rotation > 1)
    	{
    				Tweener.addTween(event.target, {_color:0xffffff, rotation:180, time:.5, y:event.target.y-10});
    
    		Tweener.addTween(mc_portfolio, {_color:0x000000, time:.5, rotation: 0, y:49});
    
    	}
    	else if(mc_about.rotation > 1)
    	{
    				Tweener.addTween(event.target, {_color:0xffffff, rotation:180, time:.5, y:event.target.y-10});
    
    		Tweener.addTween(mc_about, {_color:0x000000, time:.5, rotation: 0, y:49});
    
    	}
    	else
    	{
    						Tweener.addTween(event.target, {_color:0xffffff, rotation:180, time:.5, y:event.target.y-10});
    
    	}
    	
    	
    	}
    }
    	
    
    
    function squareMovie(event:MouseEvent):void 
    {
    	{
    		if(event.target == mc_home)
    		{
    			 Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    		     Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9], {_color:0x000000, time: 1, y :76});
    
    			
    		}
    		
    		if(event.target == mc_about)
    		{
    						 Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    						 Tweener.addTween([s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20], {_color:0x000000, time: 1, y :76});
    
    			
    		}
    		
    		if(event.target == mc_portfolio)
    		{
    						 Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    						 Tweener.addTween([s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31], {_color:0x000000, time: 1, y :76});
    
    			
    		}
    		if(event.target == mc_why)
    		{
    						 Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    						 Tweener.addTween([s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x000000, time: 1, y :76});
    
    		}
    		
    	
    	
    }
    
    }
    
    mc_why.addEventListener(MouseEvent.CLICK,
    squareMovie);
    mc_home.addEventListener(MouseEvent.CLICK,
    squareMovie);
    mc_about.addEventListener(MouseEvent.CLICK,
    squareMovie);
    mc_portfolio.addEventListener(MouseEvent.CLICK,
    squareMovie);
    
    mc_why.addEventListener(MouseEvent.CLICK,
    startMovie);
    mc_home.addEventListener(MouseEvent.CLICK,
    startMovie);
    mc_about.addEventListener(MouseEvent.CLICK,
    startMovie);
    mc_portfolio.addEventListener(MouseEvent.CLICK,
    startMovie);

  2. #2
    Ө_ө sleepy mod
    Join Date
    Mar 2003
    Location
    Oregon, USA
    Posts
    2,441
    Apart from being a little messy, there's not a lot you can do to optimize that...the only thing I'd recommend is to save those big arrays into variables.

    PHP Code:
    var bigArray:Array = [s1s2s3s4s5s6 ,s7s8s9s10s11s12s13s14s15s16s17s18s19s20s21s22s23s24s25s26s27s28s29s30s31s32s33s34s35s36s37s38s39s40];
    //...
        
        
    Tweener.addTween(bigArray, {_color:0x666666time1:72.3}); 

  3. #3
    Junior Member
    Join Date
    Jun 2008
    Posts
    8
    I didn't even think of using arrays, that will save me so much time thanks alot

  4. #4
    Member
    Join Date
    Dec 2006
    Posts
    52
    also instead of using a ton of if statements you could use a switch case statement:

    Code:
        switch(event.target)
       {
               case mc_home:
    	        Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    		Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9], {_color:0x000000, time: 1, y :76});
                   break;
               
               case mc_about:
    		Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    		Tweener.addTween([s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20], {_color:0x000000, time: 1, y :76});
                    break;
    		
               case mc_portfolio:
    		Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    	        Tweener.addTween([s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31], {_color:0x000000, time: 1, y :76});
                    break;
    
    	   case mc_why:
    		Tweener.addTween([s1, s2, s3, s4, s5, s6 ,s7, s8, s9, s10, s11, s12, s13, s14, s15, s16, s17, s18, s19, s20, s21, s22, s23, s24, s25, s26, s27, s28, s29, s30, s31, s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x666666, time: 1, y :72.3});
    	        Tweener.addTween([s32, s33, s34, s35, s36, s37, s38, s39, s40], {_color:0x000000, time: 1, y :76});
                    break;
    
        }
    dosnt really change anything, just cleans up your code a bit.
    switch case statements can replace alot of if.. else statements if you are just comparing one thing to be equal to alot of others (in this case event.target)
    Last edited by benthejack; 07-04-2008 at 11:38 AM.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  




Click Here to Expand Forum to Full Width

HTML5 Development Center