Bullet off stage - remove

[swordfish123]

Hi,

I want to remove bullets when they go off stage.
MoveBullet is my function that animates the bullet.

if(e.target.x > stage.stageWidth){
     e.target.removeListener(Event.ENTER_FRAME, moveBullet);
     removeChild(MovieClip(e.target));
     trace("out");
}

My error output:

TypeError: Error #1006: removeListener is not a function.
at shooting_fla::MainTimeline/moveBullet()


if I comment away the "removeListener line" I get the following error:

ArgumentError: Error #2025: The supplied DisplayObject must be a child of the caller.
at flash.display:isplayObjectContainer/removeChild()
at shooting_fla::MainTimeline/moveBullet()


What could be the problem?

/S-fish

[florianvanthuyn]

Try:

e.target.removeEventListener(Event.ENTER_FRAME, moveBullet);
MovieClip(parent).removeChild(e.target);

[neznein9]

One small correction: You need to scope parent correctly -

DisplayObjectContainer(e.target.parent).removeChild(e.target); 

Also, you could use weak event listeners and let them clean up after themselves automatically.

[swordfish123]

No this doesn't work for me..I got an error output:

1118: Implicit coercion of a value with static type Object to a possibly unrelated type flash.displayisplayObject.


Any idea? Maby I should try weak event listeners in this case...

[neznein9]

Can you post the code where you attach the eventListener?

[swordfish123]

Here is some of the code, on mousePress the "shoot" variable is set to true and on release false:

stage.addEventListener(Event.ENTER_FRAME, onFrameLoop);

//loop for creating new bullets and get the direction
function onFrameLoop(evt:Event){

    if (shoot){ 
			
	var bullet:Bullet = new Bullet();
	addChild(bullet);
						
	bullet.xMove = shotSpeed * dir;
	bullet.yMove = shotSpeed * dir;
			
	bullet.addEventListener(Event.ENTER_FRAME, moveBullet);		
     }
}

//function for moving the bullet
function moveBullet(e:Event){
	
	e.target.x += e.target.xMove;
	e.target.y += e.target.yMove;
	
	if(e.target.x > stage.stageWidth){ 
                   //This does part not work!
                  //e.target.removeEventListener(Event.ENTER_FRAME, moveBullet);
                  //DisplayObjectContainer(e.target.parent).removeChild(e.target);		
	}
	
	//trace(e.target.x);
}

[neznein9]

Give this a try:

//function for moving the bullet
function moveBullet(e:Event){
    var b:Bullet = Bullet(e.target);
    b.x += b.xMove
    b.y += b.yMove;

    if(b.x > stage.stageWidth){
        b.removeEventListener(Event.ENTER_FRAME, moveBullet);
        b.parent.removeChild(b);
    }
} 

[swordfish123]

Thank you, this works for me!