Removing Child isssue.. probably v easy problem..

[jamrobot]

when this health crate goes below the screen and i try to remove it, it throws up error:

ArgumentError: Error #2025: The supplied DisplayObject must be a child of the caller.
at flash.display:isplayObjectContainer/removeChild()
at Game_new6_fla::MainTimeline/cratestuff()

var cratetimer:Timer=new Timer(3000);
cratetimer.addEventListener (TimerEvent.TIMER, addcrate);
cratetimer.start ();


var mycrate:crate = new crate();//mybullet=instancename, bullet=class
function addcrate (evt:TimerEvent):void{
    addChild (mycrate);
    mycrate.x=(mydude.width)+((stage.stageWidth-mydude.width)*Math.random());
    mycrate.y=((stage.stageHeight-(2*mydude.height))*Math.random());
	
}

stage.addEventListener (Event.ENTER_FRAME, cratestuff);
function cratestuff (evt:Event):void{
	mycrate.y += sceneryspeed
	if(mycrate.y>stage.stageHeight+10){ //removes crates below the screen
					removeChild(mycrate);
				}
	if (mydude.hitTestObject(this.mycrate)){
		
		healthbar.scaleY=healthbar.scaleY*1.03;
	}
}

What to do?

[Beathoven]

In your function addCrate, put this:

stage.addCrate(myCrate);

instead of this:

addCrate(myCrate);

and in your function cratestuff, put this:

stage.removeChild(myCrate);

Try that, lemme know if that works.

[jamrobot]

nope still the same error

[cessnajumpin]

It may be because you're removing it in an onEnterFrame function. Which means that it is going to continue to try to remove and already removed crate.
Try adding a boolean to make sure that the crate is only removed once.

var crateOnStage:Boolean = true;

and then in the remove code

function cratestuff (evt:Event):void{
if(crateOnStage)
{
	mycrate.y += sceneryspeed
	if(mycrate.y>stage.stageHeight+10){ //removes crates below the screen
					removeChild(mycrate);
                                        crateOnStage = false;
				}
	if (mydude.hitTestObject(this.mycrate)){
		
		healthbar.scaleY=healthbar.scaleY*1.03;
	}
}
}

[Beathoven]

nope still the same error

function cratestuff (evt:Event):void{
	mycrate.y += sceneryspeed
	if(mycrate.y>stage.stageHeight+10){ //removes crates below the screen
					trace(mycrate);
					trace(mycrate.parent);
				}
	if (mydude.hitTestObject(this.mycrate)){
		
		healthbar.scaleY=healthbar.scaleY*1.03;
	}
}

lemme know what that returns in the output window.

[Beathoven]

It may be because you're removing it in an onEnterFrame function. Which means that it is going to continue to try to remove and already removed crate.
Try adding a boolean to make sure that the crate is only removed once.

var crateOnStage:Boolean = true;

and then in the remove code

if(mycrate.y>stage.stageHeight+10 && crateOnStage){
crateOnStage = false;
removeChild(mycrate);
}

Good call. Try that too.

[jamrobot]

function cratestuff (evt:Event):void{
	mycrate.y += sceneryspeed
	if(mycrate.y>stage.stageHeight+10){ //removes crates below the screen
					trace(mycrate);
					trace(mycrate.parent);
				}
	if (mydude.hitTestObject(this.mycrate)){
		
		healthbar.scaleY=healthbar.scaleY*1.03;
	}
}

lemme know what that returns in the output window.

[object crate]
[object MainTimeline]
[object crate]
[object MainTimeline]
[object crate]
[object MainTimeline]

is what comes up

[jamrobot]

It may be because you're removing it in an onEnterFrame function. Which means that it is going to continue to try to remove and already removed crate.
Try adding a boolean to make sure that the crate is only removed once.

var crateOnStage:Boolean = true;

and then in the remove code

function cratestuff (evt:Event):void{
if(crateOnStage)
{
	mycrate.y += sceneryspeed
	if(mycrate.y>stage.stageHeight+10){ //removes crates below the screen
					removeChild(mycrate);
                                        crateOnStage = false;
				}
	if (mydude.hitTestObject(this.mycrate)){
		
		healthbar.scaleY=healthbar.scaleY*1.03;
	}
}
}

this also doesnt work , same error every milisecond:


ArgumentError: Error #2025: The supplied DisplayObject must be a child of the caller.
at flash.display:isplayObjectContainer/removeChild()
at Game_newstory_fla::MainTimeline/cratestuff()

[v5000]

A sloppy fix would be:
if ( mycrate.parent ) mycrate.parent.removeChild(mycrate);

[jamrobot]

A sloppy fix would be:
if ( mycrate.parent ) mycrate.parent.removeChild(mycrate);

that is ok but when i restart the game, some crates stay on the stage and dont have any effect. Is there any way to get rid of all crate class objects on the next frame?

[v5000]

You could store all your crates in an array, then when you want to clear them call a function that loops through the array, removing them as needed. Something like below:

var crates:Array = new Array();
var mycrate:crate = new crate();//mybullet=instancename, bullet=class
function addcrate (evt:TimerEvent):void{
    crates.push( addChild (mycrate) );
    mycrate.x=(mydude.width)+((stage.stageWidth-mydude.width)*Math.random());
    mycrate.y=((stage.stageHeight-(2*mydude.height))*Math.random());
    
}
function clearCrates():void{
    while( crates.length ){
        var mycrate:crate = crates.pop();
        if ( mycrate.parent ) mycrate.parent.removeChild(mycrate);
    }
} 

[jamrobot]

what does pop mean?

[cessnajumpin]

pop removes an element from the end of an array. Also, for future posts, try to mention things like there is more than one crate with that instance name at the beginning of the post. It helps knowing that from the get go.

[jamrobot]

if i die and the crate is on the screen, it just stays there, whats a proper way to remove all children of a class or an array