[F8] Combo system: best approach ??

In my engine, I need players to be able to perform combos when attacking.

The concept I had for this is to use an array to buffer method references that correspond to the attacks that are being keyed in, then simply call each method and perform each attack until either the combo is completed or a condition arises that would halt the remainder of the buffer (at which point the entire buffer would be zeroed out.)

Is this a sensible approach?

that makes sense

if you have a combo buffer and you hit the attack button does it then add that attack to the buffer? or is this only for speacial attack combinations (assuming there are multiple buttons to attack)
If it is the later then you might want to make another variable specifying what location you are in the combo so you don't have to scan through the array each time to determine what other keys can be pressed.