Line between 2 points

I am trying to create an activity which will test the user’s ability to identify the correct areas to measure between of 4 separate points. So they click once and that is position 1, they then click again and that is position 2. A line would then be draw dynamically between the two points. The user would then be required to click a 3rd and 4th time with a separate line being drawn between these points. The following code is almost right but it requires the user to click and hold the mouse down rather than click and release:

this.onMouseDown = function()
{
var n:Number = this.getNextHighestDepth();
var mc:MovieClip = this.createEmptyMovieClip("mc" + n, n);

var x0:Number = _xmouse;
var y0:Number = _ymouse;


this.onMouseMove = function()
{
mc.clear();
mc.lineStyle(1);
mc.moveTo(x0,y0);
mc.lineTo(_xmouse,_ymouse);

updateAfterEvent();
};
};

this.onMouseUp = function()
{
delete this.onMouseMove;
};

Actionscript Code:

down = false;

this.onMouseDown = function() 
{ 

    n = this.getNextHighestDepth(); 
    mc = this.createEmptyMovieClip("mc" + n, n); 
    
    x0 = _xmouse; 
    y0 = _ymouse; 

}


this.onMouseMove = function() 
{ 
    if(down){
        mc.clear(); 
        mc.lineStyle(1); 
        mc.moveTo(x0,y0); 
        mc.lineTo(_xmouse,_ymouse); 
        
        updateAfterEvent(); 
    }
};  

this.onMouseUp = function() 
{ 
    x0 = _xmouse; 
    y0 = _ymouse;
    down = !down;
};
};

Standalone thats works a treat. However I tried to add to the attched movie and it only works after i have clicked 4 times....

Please post in CS5 or lower

cheers. here it is.

Because you can only have one event handler (e.g., onMouseMove, onMouseDown, onMouseUp) per object, and if you just copied and pasted it, then you'd be overriding the current event handlers with the new ones (or vice versa). To solve this, simply add the codes to their respective current event handlers:

Actionscript Code:

down = false;

this.onMouseMove = function() 
{ 
    if(down){
        mc.clear(); 
        mc.lineStyle(1); 
        mc.moveTo(x0,y0); 
        mc.lineTo(_xmouse,_ymouse); 
        
        updateAfterEvent(); 
    }
};  
 
onMouseDown = function(){
    if(i < 4){
        attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
        i++;
        if(rump_bt.hitTest(_xmouse, _ymouse, true)){
            rump = 1;
        } else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
            crown = 1;
        } else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
            sides = 1;
        } else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
            yolk = 1;
        }
    }
    
    n = this.getNextHighestDepth(); 
    mc = this.createEmptyMovieClip("mc" + n, n); 
    
    x0 = _xmouse; 
    y0 = _ymouse;
}
 
onMouseUp = function(){ 
    if((rump == 1) && (yolk== 1)) {
    i = 4;
    submit_bt._visible = true;
    }
    if((rump == 1) && (sides== 1)) {
    i = 4;
    submit_bt._visible = true;
    }
    if((sides == 1) && (crown== 1)) {
    i = 4;
    submit_bt._visible = true;
    }
    if((yolk == 1) && (crown== 1)) {
    i = 4;
    submit_bt._visible = true;
    }
    if((rump == 1) && (crown == 1)) {
 ab_dash._visible = true;
    }
    if((sides == 1) && (yolk == 1)) {
 cd_dash._visible = true;
    }
    if(i == 4 && ended == false){       
        submit_bt._visible = true;
    }
    
    x0 = _xmouse; 
    y0 = _ymouse;
    down = !down;
}

Mmmmmm I see what you mean. Few problems with this code now:

1. Hotspot areas that should not be visible at all are visible now
2. The fixed dotted lines that should only be visible once the user has clicked 'Reveal' are visible from the start.
3. The dynamic lines once drawn should not dissapear
4. Once two lines have been drawn (4 points) the submit button should appear and the user should not be able to continue drawing lines.

AHHHHHH help!!!!!!

Ok, I am making slow progress. This now works perfectly after you have clicked the submit and then retry button. Eg the dynamic lines are created and stay visible. Any idea why they dissappear on the first attempt?

i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

down = false;

this.onMouseMove = function()
{
if(down && i < 4){
mc.clear();
mc.lineStyle(5, 0xFFFFFF, 100);
mc.moveTo(x0,y0);
mc.lineTo(_xmouse,_ymouse);
updateAfterEvent();
}
};


onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
i++;
if(rump_bt.hitTest(_xmouse, _ymouse, true)){
rump = 1;
} else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
crown = 1;
} else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
sides = 1;
} else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
yolk = 1;
}
}

n = this.getNextHighestDepth();
mc = this.createEmptyMovieClip("mc" + n, n);

x0 = _xmouse;
y0 = _ymouse;
}



onMouseUp = function(){
if(i == 4){
submit_bt._visible = true;
}

x0 = _xmouse;
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((rump == 1) && (crown == 1) && (yolk == 1) && (sides == 1)) {
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at right angles to each other.";
submit_bt._visible = false;
} else if((rump == 1) || (crown == 1) || (yolk == 1) || (sides == 1)) {
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
} else {
feedback.htmlText = "<b>Incorrect.</b>\n\nMake sure to select the two abdominal diameters in the correct order.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
}


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

Change this line:

Code:

---

n = this.getNextHighestDepth();

---

to this:

Actionscript Code:

n = this.getNextHighestDepth()+4;

because the Plus marks are using the depths 0 through 3, and the first lines created overlap those, making the new Plus signs take over the first created lines, causing them to disappear (replacing them), so instead, you start at a higher depth

Excellent, thank you! Just need the retry button to clear all draw lines now. I thought ‘mc.clear();’ would achieve this but it doesn’t?

mc is just a variable which stores the latest created line, so clearing it would be futile. Instead, we give the lines a custom depth range, and remove them according to that and add new ones on those depths, full new code:

Actionscript Code:

i = 0;
n = 4;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

down = false;

this.onMouseMove = function()
{ 
if(down && i < 4){
mc.clear(); 
mc.lineStyle(5, 0xFFFFFF, 100); 
mc.moveTo(x0,y0); 
mc.lineTo(_xmouse,_ymouse); 
updateAfterEvent(); 
}
};


onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
i++;
if(rump_bt.hitTest(_xmouse, _ymouse, true)){
rump = 1;
} else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
crown = 1;
} else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
sides = 1;
} else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
yolk = 1;
}
}
 
mc = this.createEmptyMovieClip("mc" + n, n);
n++;

x0 = _xmouse; 
y0 = _ymouse;
}



onMouseUp = function(){ 
if(i == 4){ 
submit_bt._visible = true;
}

x0 = _xmouse; 
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((rump == 1) && (crown == 1) && (yolk == 1) && (sides == 1)) {
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at right angles to each other.";
submit_bt._visible = false;
} else if((rump == 1) || (crown == 1) || (yolk == 1) || (sides == 1)) {
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
} else {
feedback.htmlText = "<b>Incorrect.</b>\n\nMake sure to select the two abdominal diameters in the correct order.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
} 


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);

}
for(k=4;k<n+1;k++){
    removeMovieClip(_root["mc"+k]);
}
n = 4;

i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

Perfect, thank you!

One last thing.....what would be the best way to identify if the clicks have not only be made on the correct hotspots but also in the correct order? eg clicking point A then point B, then point C then point D is fine but if they click point A then C, then D then B? the end result in terms of variables is the same but it would be incorrect.

Actionscript Code:

i = 0;
n = 4;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

points = 0;
correct = false;

down = false;

this.onMouseMove = function()
{ 
if(down && i < 4){
mc.clear(); 
mc.lineStyle(5, 0xFFFFFF, 100); 
mc.moveTo(x0,y0); 
mc.lineTo(_xmouse,_ymouse); 
updateAfterEvent(); 
}
};


onMouseDown = function(){
    if(i < 4){
        attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
        if(rump_bt.hitTest(_xmouse, _ymouse, true)){
            rump = 1;
        } else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
            crown = 1;
        } else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
            sides = 1;
        } else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
            yolk = 1;
        }
        
        if(i == 0){
            if(sides == 1){
                points++;
            }
        } else if(i == 1){
            if(yolk == 1){
                points++;
            }
        } else if(i == 2){
            if(rump == 1){
                points++;
            }
        } else if(i == 3){
            if(crown == 1){
                points++;
            }
        }
        if(points == 4){
            correct = true;
        }
        i++;
    }
 
mc = this.createEmptyMovieClip("mc" + n, n);
n++;

x0 = _xmouse; 
y0 = _ymouse;
}



onMouseUp = function(){ 
if(i == 4){ 
submit_bt._visible = true;
}

x0 = _xmouse; 
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((rump == 1) && (crown == 1) && (yolk == 1) && (sides == 1)) {
    if(correct == true){
        cover_bt._visible = true;
        feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at right angles to each other.";
        submit_bt._visible = false;
    } else {
        feedback.htmlText = "<b>Incorrect.</b>\n\nCorrect spots, wrong order.";
        reveal_bt._visible = true;
        retry_bt._visible = true;
        submit_bt._visible = false;
    }
} else if((rump == 1) || (crown == 1) || (yolk == 1) || (sides == 1)) {
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
} else {
feedback.htmlText = "<b>Incorrect.</b>\n\nMake sure to select the two abdominal diameters in the correct order.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
} 


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);

}
for(k=4;k<n+1;k++){
    removeMovieClip(_root["mc"+k]);
}
n = 4;
points = 0;

i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

Hi Nig, that is awesome and exactly what I needed.....i say 'what' as the client has now changed their mind.....nice.

So what they want now is for the user to be able to click 4 points anywhere on the circumference and as long as the 2 lines the 4 points draw are more or less 90 degrees to each other it would be fine. Can this be done?

This one was hard to do, but with a bit of help from Google on how to find the angle between two points, I managed to do it, but not 100% though, as it counts if the first marker's coordinates is greater or less than the second's one.

In the onMouseUp function, find this:

Actionscript Code:

if(i == 4){ 
submit_bt._visible = true;
}

Change it to this:

Actionscript Code:

if(i == 4){ 
submit_bt._visible = true;
    
    diff1X = marker1._x - marker0._x;
    diff1Y = marker1._y - marker0._y;
    diff2X = marker3._x - marker2._x;
    diff2Y = marker3._y - marker2._y;
    diff1 = (Math.atan2(diff1Y, diff1X)*180/Math.PI)+180;
    diff2 = (Math.atan2(diff2Y, diff2X)*180/Math.PI)+180;
    difference = Math.abs(diff1-diff2);
    trace(difference);

}

The angle is in Degrees (not radians), but if you want it in radians, then just remove *180/Math.PI)+180, because Math.atan2 returns the angle of a vector in radians, but using the radians to degrees formula, I converted it, but that returned from 0 to 180 and -180 to 0, not from 0 to 360, which is why I've included +180, you may remove that as well if you wish to preserve the calculation in radians. See the image below for how the degrees work in the calculation above:

http://i47.tinypic.com/33mvcqh.png

Hope it works though, I can't do anything further, sorry.

Thanks once again. Just to make sure i have got my head around this correctly; I now need to check the variable 'difference' is between say 80 and 100 (to give a bit of room for error) on submit?

Something like:

submit_bt.onRelease = function() {
ended = true;
if(difference > 80 || < 100) {
if(correct == true){
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at right angles to each other.";
submit_bt._visible = false;
} else {
feedback.htmlText = "<b>Incorrect.</b>\n\nMake sure to select the two abdominal diameters in the correct order.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
}

Code:

---

if(difference > 80 || < 100) {

---

that is incorerct, as after the || sign, a new condition starts, meaning that it has no connection to the previous one. In other words, you need to specify the full condition again. Also, when you want to check if it's between 2 values, you use && (AND):

Actionscript Code:

if(difference > 80 && difference < 100) {

Thanks again. So close now.....just 2 issues left.

1. Is is possible to make the dynamic lines dotted?
2. All feedback appears at the correct time apart from when you get evrything wrong. eg the angle between the lines is incorrect as is the placement of the start and end points of the lines. I have ref the code below:

i = 0;
n = 4;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

points = 0;
correct = false;

down = false;

this.onMouseMove = function()
{
if(down && i < 4){
mc.clear();
mc.lineStyle(2, 0xFFFF00, 100);
mc.moveTo(x0,y0);
mc.lineTo(_xmouse,_ymouse);
updateAfterEvent();
}
};


onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
if(rump_bt.hitTest(_xmouse, _ymouse, true)){
rump = 1;
} else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
crown = 1;
} else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
sides = 1;
} else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
yolk = 1;
}

if(i == 0){
if(sides == 1){
points++;
}
} else if(i == 1){
if(yolk == 1){
points++;
}
} else if(i == 2){
if(rump == 1){
points++;
}
} else if(i == 3){
if(crown == 1){
points++;
}
}
if(points == 4){
correct = true;
}
i++;
}

mc = this.createEmptyMovieClip("mc" + n, n);
n++;

x0 = _xmouse;
y0 = _ymouse;
}



onMouseUp = function(){
if(i == 4){
submit_bt._visible = true;
diff1X = marker1._x - marker0._x;
diff1Y = marker1._y - marker0._y;
diff2X = marker3._x - marker2._x;
diff2Y = marker3._y - marker2._y;
diff1 = (Math.atan2(diff1Y, diff1X)*180/Math.PI)+180;
diff2 = (Math.atan2(diff2Y, diff2X)*180/Math.PI)+180;
difference = Math.abs(diff1-diff2);
trace(difference);
degree.text = difference;
}
x0 = _xmouse;
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((difference > 85) && (difference < 95) && (correct == true))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct and the 4 points are all correctly placed.
{
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at the abdominal circumference and at right angles to each other.";
submit_bt._visible = false;
} else if((difference < 85) || (difference > 95) && (correct == true))
//The angle between the two lines is either less than 85 degrees or greater than 95 degress but the 4 points are all correctly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
else if((difference > 85) && (difference < 95) && (correct == false))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct but one/all of 4 points are incorrectly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nEach of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
else if((difference < 85) || (difference > 95) && (correct == false))
//The angle between the two lines is either less than 85 degrees or greater than 95 degress and one/all of 4 points are incorrectly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other and each of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}}


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);

}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
n = 4;
points = 0;
degree.text = ""
i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

1. Nope, not possible to make dotted lines (only in AS3), unless, of course if we drew many lines, but that'd require a lot of coding and also re-write the current coding, so let's just leave it as it is right now.
2. It's working perfectly here. For the 2 codes that are like this:

Actionscript Code:

if((difference < 85) || (difference > 95) && (correct == true))

Instead, join the OR statements together:

Actionscript Code:

if((difference < 85 || difference > 95) && (correct == true))

and see if that makes any difference. And please, if you post anymore code, please put it in AS tags (press the button that looks like this; AS ) :p

OK sorry about that.

I am now getting errors on line 120, 128 and 137. saying there is 'else' encountered without matching 'if'?

Actionscript Code:

i = 0;
n = 4;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

points = 0;
correct = false;

down = false;

this.onMouseMove = function()
{ 
if(down && i < 4){
mc.clear(); 
mc.lineStyle(2, 0xFFFF00, 100); 
mc.moveTo(x0,y0); 
mc.lineTo(_xmouse,_ymouse); 
updateAfterEvent(); 
}
};


onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
if(rump_bt.hitTest(_xmouse, _ymouse, true)){
rump = 1;
} else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
crown = 1;
} else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
sides = 1;
} else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
yolk = 1;
}

if(i == 0){
if(sides == 1){
points++;
}
} else if(i == 1){
if(yolk == 1){
points++;
}
} else if(i == 2){
if(rump == 1){
points++;
}
} else if(i == 3){
if(crown == 1){
points++;
}
}
if(points == 4){
correct = true;
}
i++;
}

mc = this.createEmptyMovieClip("mc" + n, n);
n++;

x0 = _xmouse; 
y0 = _ymouse;
}



onMouseUp = function(){ 
if(i == 4){ 
submit_bt._visible = true;
diff1X = marker1._x - marker0._x;
diff1Y = marker1._y - marker0._y;
diff2X = marker3._x - marker2._x;
diff2Y = marker3._y - marker2._y;
diff1 = (Math.atan2(diff1Y, diff1X)*180/Math.PI)+180;
diff2 = (Math.atan2(diff2Y, diff2X)*180/Math.PI)+180;
difference = Math.abs(diff1-diff2);
trace(difference);
degree.text = difference;
}
x0 = _xmouse; 
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((difference > 85) && (difference < 95) && (correct == true))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct and the 4 points are all correctly placed. 
{
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at the abdominal circumference and at right angles to each other.";
submit_bt._visible = false;
} 
else if((difference < 85 || difference > 95) && (correct == true))
//The angle between the two lines is either less than 85 degrees or greater than 95 degress but the 4 points are all correctly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
else if((difference > 85) && (difference < 95) && (correct == false))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct but one/all of 4 points are incorrectly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nEach of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
//The angle between the two lines is either less than 85 degrees or greater than 95 degress and one/all of 4 points are incorrectly placed.
else if ((difference < 85 || difference > 95) && (correct == false))
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other and each of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}}


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);

}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
n = 4;
points = 0;
degree.text = ""
i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

I am not getting any errors with the code you posted :S

Thats strange, could you open the attached and see if you get any?

Nope, no errors. Maybe it's because of CS5.5? :p

Thanks so much for all your help. The attached is 95% there but for some reason dosnt seem to operate consistanly. If the users click 4 times anywhere on the circumference area and those 4 points draw two lines which are more or less 90 degrees apart then it should be correct. But i am getting mixed result and am not sure why?

What do you mean, I don't get it, it works perfectly here???

Quote:

---

If the users click 4 times anywhere on the circumference area and those 4 points draw two lines which are more or less 90 degrees apart then it should be correct.

---

Have you changed your mind? You said in an earlier post that you wanted the 4 parts to be selected in a specific order :S?

i think the problem is here:

Actionscript Code:

onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});

Add "};" to close the if

Actionscript Code:

onMouseDown = function(){
if(i < 4){
attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
};

Hi, yes, the requirement has changed and simplified i guess...but i cant work out how to simplyfy the code i have....

Anyone?????

Sorry mileso. I reed your thread weeks ago, i looked to your fla but i'm not familiarized with scripted vectors, pixeles, bitmaps. Maybe our friend Nig13 can help you? Nig!!! *Bump*

What do you really want to do right now?

Actionscript Code:

onMouseDown = function(){
    if(i < 4+1){

Now you can create 4 crosshairs and form the cross. Before that, you could only create 3.

Hi,

sorry for the long wait, I was busy :P

If the requirement has been changed, then simply remove the code which checks the order:

Actionscript Code:

if(i == 0){
if(sides == 1){
points++;
}
} else if(i == 1){
if(yolk == 1){
points++;
}
} else if(i == 2){
if(rump == 1){
points++;
}
} else if(i == 3){
if(crown == 1){
points++;
}
}
if(points == 4){
correct = true;
}
i++;
}

and then change the code a bit to not check for points variable, making the new code something like this:

Actionscript Code:

i = 0;
n = 4;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;

points = 0;
correct = false;

down = false;

this.onMouseMove = function()
{ 
if(down && i < 4){
mc.clear(); 
mc.lineStyle(2, 0xFFFF00, 100); 
mc.moveTo(x0,y0); 
mc.lineTo(_xmouse,_ymouse); 
updateAfterEvent(); 
}
};


onMouseDown = function(){
    if(i < 4){
        attachMovie("marker_mc", "marker"+i, i, {_x:_xmouse, _y:_ymouse});
        if(rump_bt.hitTest(_xmouse, _ymouse, true)){
        rump = 1;
        } else if(crown_bt.hitTest(_xmouse, _ymouse, true)){
        crown = 1;
        } else if(sides_bt.hitTest(_xmouse, _ymouse, true)){
        sides = 1;
        } else if(Yolk_bt.hitTest(_xmouse, _ymouse, true)){
        yolk = 1;
        }

        i++;

        mc = this.createEmptyMovieClip("mc" + n, n);
        n++;

        x0 = _xmouse; 
        y0 = _ymouse;
    }
}



onMouseUp = function(){ 
if(i == 4){ 
submit_bt._visible = true;
diff1X = marker1._x - marker0._x;
diff1Y = marker1._y - marker0._y;
diff2X = marker3._x - marker2._x;
diff2Y = marker3._y - marker2._y;
diff1 = (Math.atan2(diff1Y, diff1X)*180/Math.PI)+180;
diff2 = (Math.atan2(diff2Y, diff2X)*180/Math.PI)+180;
difference = Math.abs(diff1-diff2);
trace(difference);
degree.text = difference;
}
x0 = _xmouse; 
y0 = _ymouse;
down = !down;
}


background_bt._visible = false;
reveal_a._visible = false;
reveal_b._visible = false;
reveal_bt._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
submit_bt._visible = false;
yolk_arrow._visible = false;
cover_bt._visible = false;
submit_cover._visible = false;
cd_dash._visible = false;
ab_dash._visible = false;


cover_bt.useHandCursor = false;
ended = false;

Yolk_bt._visible = false;
rump_bt._visible = false;
crown_bt._visible = false;
sides_bt._visible = false;

submit_bt.onRelease = function() {
ended = true;
if((difference > 85) && (difference < 95))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct and the 4 points are all correctly placed. 
{
cover_bt._visible = true;
feedback.htmlText = "<b>Correct.</b>\n\nYou have correctly placed the two abdominal diameter measurements at the abdominal circumference and at right angles to each other.";
submit_bt._visible = false;
} 
else if((difference < 85 || difference > 95))
//The angle between the two lines is either less than 85 degrees or greater than 95 degress but the 4 points are all correctly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
else if((difference > 85) && (difference < 95))
//The angle between the two lines is between 85 degrees and 95 degress and therefore correct but one/all of 4 points are incorrectly placed.
{
feedback.htmlText = "<b>Incorrect.</b>\n\nEach of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}
//The angle between the two lines is either less than 85 degrees or greater than 95 degress and one/all of 4 points are incorrectly placed.
else if ((difference < 85 || difference > 95))
{
feedback.htmlText = "<b>Incorrect.</b>\n\nRemember that the two measurements should be at right angles to each other and each of the two measurements should touch the circumference of the abdomen.";
reveal_bt._visible = true;
retry_bt._visible = true;
submit_bt._visible = false;
}}


reveal_bt.onRelease = function () {
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);
}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
ended = true;
feedback.htmlText = "";
ab_dash._visible = true;
cd_dash._visible = true;
retry_bt._visible = false;
cover_bt._visible = true;
reveal_bt._visible = false;
submit_bt._visible = false;
reveal_a._visible = true;
reveal_b._visible = true;
yolk_arrow._visible = false;
};

retry_bt.onRelease = function (){
for(a=0;a<i;a++){
removeMovieClip(_root["marker"+a]);

}
for(k=4;k<n+1;k++){
removeMovieClip(_root["mc"+k]);
}
n = 4;
points = 0;
degree.text = ""
i = 0;
rump = 0;
crown = 0;
sides = 0;
yolk = 0;
cd_dash._visible = false;
ab_dash._visible = false;
ended = false;
cover_bt._visible = false;
yolk_arrow._visible = false;
reveal_bt._visible = false;
retry_bt._visible = false;
feedback.htmlText = "";
submit_bt._visible = false;
}

It should work...

I understand the issue. You click one point and another point, and a part of the crosshair is created. Then you click 3rd point but you can't make point 4th because when 3rd point is created, the submit button is visible and don't let you click.

I have no idea any longer as this post has been continued for so long and I've lost track of everything here. I really should learn to add comments to codes, but meh, too lazy. I dunno about the 4 click issue, as it works for me, lolz, and it looks like this guy is absent >.<"

I took my time to understand the codes, but I don't find how to make it works. If you click randomly 4 times, you'll be able to make 4 crosshairs, but if you click correctly and form the first part of the main cross, when you want to click 2 more times to make the other part of the cross, you'll only be able to make 1, the 3rd crosshair and not the 4th. I'm using the original posted FLA. I tried overwriting the original FLA with your last script, Nig, but it doesn't create the cross, it only attaches the crosshairs with the lines along.

Try it yourself, click one point, then the 2nd point and create a red or yellow line (part of the cross) then try to click 3rd point and 4th point to cread the other part of the cross (if you made the red one, now try the yellow one) and you'll see you can only make the 3rd crosshair, inmediately shows up the Submit button and you can't click anymore to create the 4th crosshair to creat the last part of the cross. And he is not abcent, he commented yesterday, that's why I commented to and tried to help. :D