Help with bullet detention with enemy

Hi guys,

For some unknown reason whilst coding my shoot em up game, the bullet detection with the enemy will suddenly becomes unfunctional (not detecting bullets) when write additional code that has nothing to do with function CollisionWithEnemies(). This has happened a few times during the development of my game and I've always worked around it, but now its got to a point where I can't that anymore.

Note: This isn't all my code as I have approx 800+ lines of code so far, that would take up too much of your time to read through so I just included the sections that would be related to this issue

The bullet detection/collision is bubbled between 3 class/documents which may be apart of the problem -

Main Class - Main logic and enemy properies of the game
Bullet Class - The bullet properies
Player Class - Player controls but in this case related cause I create the bullet here as I press a button to fire bullet - shootbullet function()

Main Class

Actionscript Code:

public function makeEnemies():void
{
    for(var i:int = 0; i < 2 + level; i++) //// This line of code changes the bullet detention from being functional to non-functional
    {
    var tempEnemy:MovieClip
    tempEnemy = new Enemy;
    addChild(enemy);
    enemies.push(tempEnemy);
    }
function checkCollisionWithEnemies(bullet:MovieClip)
          {
        if (enemy.hitTestPoint(bullet.x, bullet.y,true))
                   {
                if (player.char_type == 1)/// Square Bullets
                    {
                    enemy.meter.width -= 10;
                    enemy.gotoAndStop(2);
                    removeChild(bullet);
                    bullet = null;
                    }
                    else
                    {
                    enemy.gotoAndStop(1);
                    }
                    if (player.char_type == 3) /// Circle Bullets
                    {
                    enemy.scaleX += 0.1;
                    enemy.scaleY += 0.1;
                    enemy.meter.width += 20;
                    removeChild(bullet);
                    bullet = null;
                    }

If i remove that "for(var i:int = 0; i < 2 + level; i++)" bullet detention works fine but hasn't nothing to do with "function checkCollisionWithEnemies(bullet:MovieClip)" which is very odd.

Player Class

Actionscript Code:

private function onMouseDown(event:MouseEvent):void
        {
            if (! _shotFired)
            {
                shootBullet();
                _shotFired = true;
            }
        }
private function onMouseUp(event:MouseEvent):void
        {
            _shotFired = false;
                }

private function shootBullet():void
        {
           {  
            var bullet_type:String = "square";
            
            if (char_type == 3)
            { 
                bullet_type = "circle";
            }
            if (char_type == 1)
            { 
                bullet_type = "square";
            }
            
            //Bullet's velocity
            var bullet_Vx:Number=Math.cos(_angle) * -10;
            var bullet_Vy:Number=Math.sin(_angle) * -10;

            //Bullet's start position
            var radius:int =- 50;
            var bullet_StartX:Number = x + radius * Math.cos(_angle);
            var bullet_StartY:Number = y + radius * Math.sin(_angle);

            //Create bullet instance and add it to the stage
            var bullet:Bullet = new Bullet(bullet_Vx, bullet_Vy, bullet_StartX, bullet_StartY, bullet_type);
            parent.addChild(bullet);

Bullet Class

Actionscript Code:

private function onEnterFrame(event:Event):void
        {
                        //Rotate bullet
            rotation += 20;

            //Move bullet
            x += _vx;
            y += _vy;

                       //Stage Boundaries:
            //Top[/i]
            if (x + playerHalfWidth > stage.stageWidth)
            {
                _vx *= _friction;
                _vx *= _bounce;
                x = stage.stageWidth - playerHalfWidth;
            }
            else if (x - playerHalfWidth < 10)
            {
                _vx *= _friction;
                _vx *= _bounce;
                x = 10 + playerHalfWidth;
            }
            if (y - playerHalfHeight < 0)
            {
                _vy *= _friction;
                _vy *= _bounce;
                y = 0 + playerHalfHeight;
            }
            else if (y + playerHalfHeight > stage.stageHeight - 5)
            {
                _vy *= _friction;
                _vy *= _bounce;
                y = stage.stageHeight - playerHalfHeight - 5;
            }
            {
                MovieClip(parent).checkCollisionWithEnemies(this);
                }

The line "MovieClip(parent).checkCollisionWithEnemies(t his) ;" calls the "function checkCollisionWithEnemies(bullet:MovieClip)" within the Main class I don't understand why this isn't be called, any ideas?

Thank you for your time and reading all that and any help/suggestions would be greatly appreciated.

Thanks

Jonesy

You don't have to post your entire code, but you should post entire functions. All three of the excerpts that you've posted end in the middle of a function. It's very jarring, as if I ended this in the middle of

You cannot call checkCollisionWithEnemies from outside your makeEnemies function, because you have defined it inside makeEnemies which means that the checkCollisionWithEnemies identifier is undefined outside that function. You should have recieved a runtime error when attempting to run this. Assuming that you actually did finish your functions and it does compile in the first place.

Your indentation is better, but still problematic. For instance, you have checkCollisionWithEnemies at the same indentation level as makeEnemies, but it is actually not at the same level. You could have seen that immediately if you used a consistent and meaningful way of formatting your code.

Edit: Also, I don't know what you mean by "detention", but it's not detention. That would be being detained. Did you mean "detection"?

@ 5TonsOfFlax - Yes sorry - "detection" thats what I meant, I need to use spell check before I post and yes to your question regarding the game can be compiled with it has full finished functions, just bad code posting on my part there - sorry again.

You are right - I get error saying but the game still compiles -

Code:

---

"ReferenceError: Error #1069: Property checkCollisionWithEnemies not found on MainShapeShooter9 and there is no default value."

---

Refering to your comments -

Quote:

---

You cannot call checkCollisionWithEnemies from outside your makeEnemies function, because you have defined it inside makeEnemies which means that the checkCollisionWithEnemies identifier is undefined outside that function. You should have recieved a runtime error when attempting to run this.

---

Does this error message confirm your theory? So are you saying that "checkCollisionWithEnemies" function needs to be called in a different section of the code within the Main class/doc? Or you saying that I am calling it within the makeEnemies function and needs to removed?
Currently it is being called in the "Bullet" Class/document, not within the Main class but the properies of "checkCollisionWithEnemies" function are defined within Main class. Sorry I'm new to AS3, still learning so please bear with me.

Thanks for your time and input so far :)

Jonesy

Yes, the error message is consistent with the fact that you have defined checkCollisionWithEnemies in a way that it is invisible to outside code.

What you need to do is move the definition of checkCollisionWithEnemies outside of makeEnemies so that it becomes an instance method and not an inner function inside makeEnemies.

Thanks for your quick reply, you're been helpful although still stuck and abit puzzled as I've now placed "checkCollisionWithEnemies();" instance method in the MakeEnemies function but remains to have the same issue. I've contained below the whole code of my "Main" class and you see how checkCollisionWithEnemies isn't nested/within the makeEnemies():function, checkCollisionWithEnemies is located at the bottom with {} to split up the functions. Have I misunderstood completely? Or what do you mean by "definition of checkCollisionWithEnemies outside of makeEnemies" if this isn't the case? Sorry for the beginner questions.

Yet again thanks

Jonesy

Actionscript Code:

public class MainShapeShooter9 extends MovieClip
  {
        public var score:int = 0; //Game score
        public var level:Number = 1;
        public var enemies:Array; 
        var enemy:Enemy = new Enemy();

        private var _friction:Number;
    private var _bounce:Number;
    private var _vx:Number;
    private var _vy:Number;
    
    public var char_type:int; 

public function MainShapeShooter9()
    {
 level = 1;
score = 0;
enemies = new Array(); 
makeEnemies();
        }
public function makeEnemies():void 
{
    for(var i:int = 0; i < 2 + level; i++)
    {
    var tempEnemy:MovieClip
    tempEnemy = new Enemy;
    addChild(enemy);
    enemies.push(tempEnemy);
      addEventListener(Event.ENTER_FRAME, onEnterFrame);
      enemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
      checkCollisionWithEnemies();/// instance method which should but doesn't call the function
    }
     }
function onEnemyMove(event:Event):void
    {
      var enemy:Enemy = new Enemy(); 
      enemy.vx = enemy.x - enemy.oldX;
      enemy.vy = enemy.y - enemy.oldY;
      enemy.oldX = enemy.x;
      enemy.oldY = enemy.y;

            //Stage Boundaries
            if (enemy.x > stage.stageWidth)
            {
                enemy.vx *= _bounce;
                enemy.x = stage.stageWidth;
        
            }
            if (enemy.x < 0)
            {
                enemy.vx *= _bounce;
                enemy.x = 0;
            }
            
            //Keep the bug above the water
            if (enemy.y > stage.stageHeight - 35)
            {
                enemy.y = stage.stageHeight - 35;
                enemy.vy *= _bounce;
            }
            if (enemy.y < 0)
            {
                enemy.y = 0;
                enemy.vy *= _bounce; 
              }
            }
function onEnterFrame(event:Event):void
            {       
            if (player.hitTestObject(enemy)) 
               {
                if (player.currentFrame == 1 || player.currentFrame == 3) 
                   {
                    health.meter.width--;
                     player.nextFrame();
      }
      Collision.block(player, enemy);
      } 
      else if (player.currentFrame == 2|| player.currentFrame == 4) 
      {
      player.prevFrame();
         }  
        }
function checkCollisionWithEnemies(bullet:MovieClip)
          {
            var b:B = new B(); 
             b.x = enemy.x;
             b.y = enemy.y;
            //Enemy
            if (enemy!= null)
            {
                if (enemy.hitTestPoint(bullet.x, bullet.y,true))
                   {
                    if (player.char_type == 1)/// Square Bullets 
                    {
                    enemy.meter.width -= 10;
                    enemy.gotoAndStop(2);
                    removeChild(bullet);
                    bullet = null;
                    score +=10;
                    scoreText.text = score.toString();
                    }
                    else
                    {
                    enemy.gotoAndStop(1);
                    }
                    if (player.char_type == 3) /// Circle Bullets
                    {
                    enemy.scaleX += 0.1;
                    enemy.scaleY += 0.1;
                    enemy.meter.width += 20;
                    removeChild(bullet);
                    bullet = null;
                    score +=100;
                    scoreText.text = score.toString();
                    }
                    if (enemy.meter.width < 1)
                    {
                        enemy.stop();
                        swapProperies(enemy,b);
                        removeChild(enemy);
                        enemy = null;
                        level ++;
                        trace ("Level" + level);
                        levelText.text = level.toString();          
                        addChild(b);          
                     }
                   }

What do you have against organised code? Seriously. Here, I had to reformat it in order to read it anyway, please fix your code.

Code:

---

public class MainShapeShooter9 extends MovieClip{
  public var score:int = 0; //Game score
  public var level:Number = 1;
  public var enemies:Array;

  private var _friction:Number;
  private var _bounce:Number;
  private var _vx:Number;
  private var _vy:Number;
 
  public var char_type:int;

  public function MainShapeShooter9(){
    level = 1;
    score = 0;
    enemies = new Array();
    makeEnemies();
  }

  public function makeEnemies():void{
    for(var i:int = 0; i < 2 + level; i++){
      var tempEnemy:Enemy = new Enemy();
      addChild(tempEnemy);
      enemies.push(tempEnemy);
      addEventListener(Event.ENTER_FRAME, onEnterFrame);
      tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
    }
  }

  private function onEnemyMove(event:Event):void{
    //don't create a new one, use the one you're trying to reference.
    var enemy:Enemy = Enemy(event.currentTarget);
    enemy.vx = enemy.x - enemy.oldX;
    enemy.vy = enemy.y - enemy.oldY;
    enemy.oldX = enemy.x;
    enemy.oldY = enemy.y;

    //Stage Boundaries
    if (enemy.x > stage.stageWidth){
      enemy.vx *= _bounce;
      enemy.x = stage.stageWidth;
    }
    if (enemy.x < 0){
      enemy.vx *= _bounce;
      enemy.x = 0;
    }
    //Keep the bug above the water
    if (enemy.y > stage.stageHeight - 35){
      enemy.y = stage.stageHeight - 35;
      enemy.vy *= _bounce;
    }
    if (enemy.y < 0){
      enemy.y = 0;
      enemy.vy *= _bounce;
    }
  }

  private function onEnterFrame(event:Event):void{
    //you need to test against all your enemies.
    for (var i:int = 0; i < enemies.length; i++){
      var enemy:Enemy = enemies[i];
      if (player.hitTestObject(enemy)){
        if (player.currentFrame == 1 || player.currentFrame == 3){
          health.meter.width--;
          player.nextFrame();
        }
        Collision.block(player, enemy);
      }else if (player.currentFrame == 2|| player.currentFrame == 4){
        player.prevFrame();
      }
      //you may want to break out of the loop here if you only care about the first enemy hit.
    }
  }

  public function checkCollisionWithEnemies(bullet:MovieClip):void{
    for (var i:int = 0; i < enemies.length; i++){
      var enemy:Enemy = enemies[i];
      if (enemy.hitTestPoint(bullet.x, bullet.y,true)){
        if (player.char_type == 1){/// Square Bullets
          enemy.meter.width -= 10;
          enemy.gotoAndStop(2);
          score +=10;
          scoreText.text = score.toString();
          removeChild(bullet);
          //this line doesn't do anything to the reference you called this function with.
          bullet = null;
          break; //the bullet can only hit one enemy, right?  It can only be removed once, anyway.
        }else{
          enemy.gotoAndStop(1);
        }
        if (player.char_type == 3) {/// Circle Bullets
          enemy.scaleX += 0.1;
          enemy.scaleY += 0.1;
          enemy.meter.width += 20;
          score +=100;
          scoreText.text = score.toString();
          removeChild(bullet);
          //again, useless.
          bullet = null;
          break;
        }
        if (enemy.meter.width < 1){
          enemy.stop();
          var b:B = new B();
          b.x = enemy.x;
          b.y = enemy.y;
          swapProperties(enemy,b);
          removeChild(enemy);
          enemies.splice(i, 1);
          i--; //since the array changed, we need to revisit this index
          level++;
          trace ("Level" + level);
          levelText.text = level.toString();   
          addChild(b);       
        }
      }
  //you were missing everything after this line
    }
  }
}

---

I only corrected the formatting and the most egregious errors. There's still lots that needs to be fixed. You had set enemy to a new Enemy at the beginning, but that's not related to any of the other Enemies you create later. You access its x and y properties before you check to see if its null. You never define health, player, scoreText or levelText. I assume some or all of these are defined through stage instances. You never define swapProperties. You did not close your last if statement, function, or class. That should not compile.

You call checkEnemyCollisions inside makeEnemies, which you only call once from the constructor. In makeEnemies, you only make a single enemy, then put a DIFFERENT one on the display. And then put the new one in an array.

I haven't fixed all your errors, most of which are not coding errors, but logic errors.

Hi 5TonsOfFlax,

Thanks for your input so far, I didn't mean for you to check the whole code but thank you nevertheless and I adapted my code accordingly to your suggestions.

Regarding your comments on not defining "function swapProperties", to be honest I didn't include all the functions in the doc as I didn't want to overcomplate from current issue I'm having and also the class needs alot of editing as there is lot of old code but probably isn't needed with current code setup.

Here is the current code now but I've also included all of the left out functions in "pink" which need further tweaking to fill in with current code setup, for an example I previously had a tweak object for the enemy configuring the enemy AI/movement but with this enemy spawning system that probably won't work. Anyway thats probably for another day, but I thought put all the cards on the table so we both on the same page.

Code:

---

package
{
 

import flash.display.MovieClip;
  import flash.events.Event;
  import fl.transitions.Tween;
  import fl.transitions.TweenEvent;
  import fl.transitions.easing.*;
  import flash.display.DisplayObject;
  import flash.text.*;

public class MainShapeShooter9 extends MovieClip
  {
public var score:int = 0; //Game score
public var level:Number = 1;
public var enemies:Array;
               
public var scoreLabel:TextField = new TextField();
public var scoreText:TextField = new TextField();
public var playerHealth:TextField = new TextField();
public var levelLabel:TextField = new TextField();
public var levelText:TextField = new TextField();
               
public const SCOREBOARD_Y:Number =370;
       
private var _tweenX:Tween;
private var _tweenY:Tween;
private var _randomX:uint;
private var _randomY:uint;
private var _friction:Number;
private var _bounce:Number;
private var _vx:Number;
private var _vy:Number;
       
public var char_type:int;
   
public function MainShapeShooter9()
    {
_friction = 0.94;
 _bounce = -0.9;
char_type = 1;
level = 1;
score = 0;

//Select a random stage position
_randomX = Math.ceil(Math.random() * 400);
_randomY = Math.ceil(Math.random() * 400);

scoreLabel.text = "Score";
scoreText.text ="0";
playerHealth.text = "Player Health";
levelLabel.text = "Level:";
levelText.text ="1";
               
      scoreLabel.y = SCOREBOARD_Y;
      scoreText.y = SCOREBOARD_Y;                                                        playerHealth.y = SCOREBOARD_Y;
        levelLabel.y = SCOREBOARD_Y;
        levelText.y = SCOREBOARD_Y;
        scoreLabel.x = 5;
        scoreText.x = 50;
        playerHealth.x = 350;
        levelLabel.x = 205;
        levelText.x = 265;
               
        addChild(scoreLabel);
        addChild(scoreText);
        addChild(playerHealth);
        addChild(levelLabel);
        addChild(levelText);
               
    enemies = new Array();
        makeEnemies();
               
}public function makeEnemies():void {
        for(var i:int = 0; i < 2 + level; i++){
  var tempEnemy:Enemy = new Enemy();
addChild(tempEnemy);
enemies.push(tempEnemy);
tempEnemy.gotoAndStop(1);
addEventListener(Event.ENTER_FRAME, onEnterFrame);
tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
checkCollisionWithEnemies();

_tweenX = new Tween(tempEnemy, "x", Regular.easeInOut, tempEnemy.x, _randomX, 45, false);
_tweenY = new Tween(tempEnemy, "y", Regular.easeInOut, tempEnemy.y, _randomY, 45, false);
_tweenX.addEventListener(TweenEvent.MOTION_FINISH, onMotionFinishX);
_tweenY.addEventListener(TweenEvent.MOTION_FINISH, onMotionFinishY);
 
}function onMotionFinishX(event:Event){
var tweenObject:Tween = tempEnemy(event.currenttarget as Tween);

//Calculate new start and finish positions
 tweenObject.begin = tempEnemy.x;
 tweenObject.finish = Math.ceil(Math.random() * 400);
tweenObject.finish = player.x;
//Start the Tween object playing again
 tweenObject.start();
}function onMotionFinishY(event:Event){
var tweenObject:Tween = tempEnemy(event.currenttarget as Tween);
tweenObject.begin = enemy.y;
tweenObject.finish = Math.ceil(Math.random() * 400);
tweenObject.finish = player.y;
tweenObject.start();
    }

}function onEnemyMove(event:Event):void{
var enemy:Enemy = Enemy(event.currentTarget);
    enemy.vx = enemy.x - enemy.oldX;
    enemy.vy = enemy.y - enemy.oldY;
    enemy.oldX = enemy.x;
    enemy.oldY = enemy.y;
        enemy.gotoAndStop(1);

            //Stage Boundaries
                        if (enemy.x > stage.stageWidth)
                        {
                                enemy.vx *= _bounce;
                                enemy.x = stage.stageWidth;
               
                        }
                        if (enemy.x < 0)
                        {
                                enemy.vx *= _bounce;
                                enemy.x = 0;
                        }
                       
                        //Keep the bug above the water
                        if (enemy.y > stage.stageHeight - 35)
                        {
                                enemy.y = stage.stageHeight - 35;
                                enemy.vy *= _bounce;
                        }
                        if (enemy.y < 0)
                        {
                                enemy.y = 0;
                                enemy.vy *= _bounce;
                          }
               
}function onEnterFrame(event:Event):void{
for (var i:int = 0; i < enemies.length; i++){
var enemy:Enemy = enemies[i];{
  if (player.hitTestObject(enemy)) {
    if (player.currentFrame == 1 || player.currentFrame == 3){
      health.meter.width--;
        player.nextFrame();
      }Collision.block(player, enemy);
          Collision.block(player, tempEnemy);
      } else if (player.currentFrame == 2|| player.currentFrame == 4) {
      player.prevFrame();
        } 
        break;
        }
      }
function checkCollisionWithEnemies(bullet:MovieClip)
{for (var i:int = 0; i < enemies.length; i++) {
      var enemy:Enemy = enemies[i];  {
                if (enemy.hitTestPoint(bullet.x, bullet.y,true))
                {
                if (player.char_type == 1)/// Square Bullets {
                        enemy.meter.width -= 10;
                        enemy.gotoAndStop(2);
                        bullet = null;
                        score +=10;
                        scoreText.text = score.toString();
                        break;
}else{
enemy.gotoAndStop(1);}
if (player.char_type == 3) /// Circle Bullets
{
enemy.scaleX += 0.1;
enemy.scaleY += 0.1;
enemy.meter.width += 20;
bullet = null;
score +=100;
scoreText.text = score.toString();
break;

}if (enemy.meter.width < 1){
enemy.stop();
var b:B = new B();
b.x = enemy.x;
b.y = enemy.y;
swapProperies(enemy,b);
removeChild(enemy);
enemies.splice(i, 1);
i--;
level ++;
trace ("Level" + level);
levelText.text = level.toString();                       
addChild(b);
checkCollisionWithPlayer(player,b);}
        }       
function swapProperies(dobj1:DisplayObject, dobj2:DisplayObject):void
          {
var propertyA:Array=["x","y","width","height","rotation"]
                                               
for(var i:int = 0; i<propertyA.length;i++){
dobj2[propertyA[i]] = dobj1[propertyA[i]];}
 }
function checkCollisionWithPlayer(b:MovieClip)
          {
        if (player.hitTestObject(b))
                {
                Collision.block(player, b);
                        }                                             
                }
        }
      }

}

---

The current situation is that there is now two enemies that appear on screen, so does that mean new enemy that was just placed in the array is now placed on the stage? So I need to configure only enemies from the array to appear on stage?

Also either enemy doesn't have any detection from bullets being shot at them but one has Collision, so player can bounce off one enemy but the other enemy (tempEnemy) can appear through player - no collison defined by code:

Quote:

---

Collision.block(player, enemy); /// works
Collision.block(player, tempEnemy); /// don't work

---

The other issue is the when I add the instance method call of "checkCollisionWithEnemies();" within makeEnemies function that we were talking about before, Error appears such as

Quote:

---

1180: Call to a possibly undefined method checkCollisionWithEnemies

---

so would I need to create a varable for this method to work?
Thank you for your time and patience as I do realise that is a lot of code to take in but greatly appreciate your help, you're been very helpful so far.

Thanks again

Jonesy

You went through and re-broke all the formatting legibility I just put in. I'm sorry, but I will not read through that unformatted nonsense again. Make it legible, then I'll read it. But you'll probably find your errors while fixing your indentation anyway. I suspect you have defined functions inside of other functions again, restricting their scope.

Sorry I re-post/re-edited the code again. I've placed the functions in Bold and I've created more spaces between for the ease of reading. I hope thats a improvement.

Code:

---

package
{
  import flash.display.MovieClip;
  import flash.events.Event;
  import fl.transitions.Tween;
  import fl.transitions.TweenEvent;
  import fl.transitions.easing.*;
  import flash.display.DisplayObject;
  import flash.text.*;

public class MainShapeShooter9 extends MovieClip{
public var score:int = 0; //Game score
public var level:Number = 1;
public var enemies:Array;
               
public var scoreLabel:TextField = new TextField();
public var scoreText:TextField = new TextField();
public var playerHealth:TextField = new TextField();
public var levelLabel:TextField = new TextField();
public var levelText:TextField = new TextField();
               
public const SCOREBOARD_Y:Number =370;
       
private var _tweenX:Tween;
private var _tweenY:Tween;
private var _randomX:uint;
private var _randomY:uint;
private var _friction:Number;
private var _bounce:Number;
private var _vx:Number;
private var _vy:Number;
       
public var char_type:int;

}public function makeEnemies():void{

for(var i:int = 0; i < 2 + level; i++){
      var tempEnemy:Enemy = new Enemy();
      addChild(tempEnemy);
      enemies.push(tempEnemy);
      addEventListener(Event.ENTER_FRAME, onEnterFrame);
      tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);}
      addEventListener(Event.ENTER_FRAME, onEnterFrame);

 _tweenX = new Tween(enemy, "x", Regular.easeInOut, enemy.x, _randomX, 45, false);
 _tweenY = new Tween(enemy, "y", Regular.easeInOut, enemy.y, _randomY, 45, false);
_tweenX.addEventListener(TweenEvent.MOTION_FINISH, onMotionFinishX);
_tweenY.addEventListener(TweenEvent.MOTION_FINISH, onMotionFinishY);

function onMotionFinishX(event:Event){
var tweenObject:Tween = event.target as Tween;

//Calculate new start and finish positions
tweenObject.begin = enemy.x;
tweenObject.finish = Math.ceil(Math.random() * 400);
tweenObject.finish = player.x;
tweenObject.start();
      }
function onMotionFinishY(event:Event)
    {
      var tweenObject:Tween = event.target as Tween;
      tweenObject.begin = enemy.y;
      tweenObject.finish = Math.ceil(Math.random() * 400);
          tweenObject.finish = player.y;
      tweenObject.start();
    } 
}private function onEnemyMove(event:Event):void{
   
var enemy:Enemy = Enemy(event.currentTarget);
enemy.vx = enemy.x - enemy.oldX;
enemy.vy = enemy.y - enemy.oldY;
enemy.oldX = enemy.x;
enemy.oldY = enemy.y;

    //Stage Boundaries
    if (enemy.x > stage.stageWidth){
      enemy.vx *= _bounce;
      enemy.x = stage.stageWidth;
    }
    if (enemy.x < 0){
      enemy.vx *= _bounce;
      enemy.x = 0;
    }
    //Keep the bug above the water
    if (enemy.y > stage.stageHeight - 35){
      enemy.y = stage.stageHeight - 35;
      enemy.vy *= _bounce;
    }
    if (enemy.y < 0){
      enemy.y = 0;
      enemy.vy *= _bounce;
    }
}private function onEnterFrame(event:Event):void{

for (var i:int = 0; i < enemies.length; i++){
    var enemy:Enemy = enemies[i];{

      if (player.hitTestObject(enemy)){
      if (player.currentFrame == 1 || player.currentFrame == 3){
          health.meter.width--;
          player.nextFrame();
          }
        Collision.block(player, enemy);
   
}else if (player.currentFrame == 2|| player.currentFrame == 4){
        player.prevFrame();
}
break;
}
}

function checkCollisionWithEnemies(bullet:MovieClip){
for (var i:int = 0; i < enemies.length; i++)
{
var enemy:Enemy = enemies[i]; 
{
if (enemy.hitTestPoint(bullet.x, bullet.y,true))
{
if (player.char_type == 1)/// Square Bullets
{
enemy.meter.width -= 10;
enemy.gotoAndStop(2);
bullet = null;
score +=10;
scoreText.text = score.toString();
break;
}
else
{
enemy.gotoAndStop(1);
}
if (player.char_type == 3) /// Circle Bullets
{
enemy.scaleX += 0.1;
enemy.scaleY += 0.1;
enemy.meter.width += 20;
bullet = null;
score +=100;
scoreText.text = score.toString();
break;
}
if (enemy.meter.width < 1)
{
enemy.stop();
var b:B = new B();
b.x = enemy.x;
b.y = enemy.y;
swapProperies(enemy,b);
removeChild(enemy);
enemies.splice(i, 1);
i--;
level ++;
trace ("Level" + level);
levelText.text = level.toString();                       
addChild(b);
checkCollisionWithPlayer(player,b);}
}       
function swapProperies(dobj1:DisplayObject, dobj2:DisplayObject):void
{
var propertyA:Array=["x","y","width","height","rotation"]{
for(var i:int = 0; i<propertyA.length;i++)
{
dobj2[propertyA[i]] = dobj1[propertyA[i]];
 }
}
function checkCollisionWithPlayer(b:MovieClip)
{
if (player.hitTestObject(b)){
Collision.block(player, b);
                        }                                             
                  }
            }
      }

---

[/CODE]

What I was complaining about was the random indentation, which is still there.

Do you understand that code consists of a series of statements and expressions, some of which are nested inside others? And that your way of randomly indenting completely masks that structured nature? And that this is the cause of your inability to correctly structure things, such as not defining functions inside other functions?

Oh yes nesting, I understand what you mean - I do have problem with understanding when "{" and "}" is needed to start/end or break functions. I had the same problem when I script in Lua. Ok I give it a read through and post another with no nesting hopefully that be solution to the issues I've having but I let know either way.

Jonesy

Actionscript Code:

package 
{
  import flash.display.MovieClip;
  import flash.events.Event;
  import fl.transitions.Tween;
  import fl.transitions.TweenEvent;
  import fl.transitions.easing.*;
  import flash.display.DisplayObject; 
  import flash.text.*; 

  public class MainShapeShooter11 extends MovieClip
   {
        public var score:int = 0; //Game score
        public var level:Number = 1;
        public var enemies:Array; 
        
        public var scoreLabel:TextField = new TextField();
        public var scoreText:TextField = new TextField();
        public var playerHealth:TextField = new TextField();
        public var levelLabel:TextField = new TextField();
        public var levelText:TextField = new TextField();
        
        public const SCOREBOARD_Y:Number =370;
    
    private var _tweenX:Tween;
    private var _tweenY:Tween;
    private var _randomX:uint;
    private var _randomY:uint;
    private var _friction:Number;
    private var _bounce:Number;
    private var _vx:Number;
    private var _vy:Number;
    
    public var char_type:int; 
    
    public function MainShapeShooter11()
    {
     
      _friction = 0.94;
      _bounce = -0.9;
      char_type = 1;
      level = 1;
      score = 0;
     
      //Select a random stage position
      _randomX = Math.ceil(Math.random() * 400);
      _randomY = Math.ceil(Math.random() * 400);

      //Create Tween objects for the x and y axes
      
        scoreLabel.text = "Score"; 
        scoreText.text ="0";
        playerHealth.text = "Player Health";
        levelLabel.text = "Level:";
        levelText.text ="1";
        
        scoreLabel.y = SCOREBOARD_Y;
        scoreText.y = SCOREBOARD_Y;
        playerHealth.y = SCOREBOARD_Y;
        levelLabel.y = SCOREBOARD_Y;
        levelText.y = SCOREBOARD_Y;
        scoreLabel.x = 5;
        scoreText.x = 50;
        playerHealth.x = 350;
        levelLabel.x = 205;
        levelText.x = 265;
        
        addChild(scoreLabel);
        addChild(scoreText);
        addChild(playerHealth);
        addChild(levelLabel);
        addChild(levelText);
        
      //Add enemy listeners 
    enemies = new Array(); 
    makeEnemies();
        }

public function makeEnemies():void 
{
    for(var i:int = 0; i < 2 + level; i++)
    {
    var tempEnemy:Enemy = new Enemy();
    addChild(tempEnemy);
    enemies.push(tempEnemy);
    tempEnemy.gotoAndStop(1);
     addEventListener(Event.ENTER_FRAME, onEnterFrame);
     tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
     
     _tweenX = new Tween(tempEnemy, "x", Regular.easeInOut, tempEnemy.x, _randomX, 45, false);
     _tweenY = new Tween(tempEnemy, "y", Regular.easeInOut, tempEnemy.y, _randomY, 45, false);
     }
   
function onEnemyMove(event:Event):void
    {
     var enemy:Enemy = Enemy(event.currentTarget);
     enemy.vx = enemy.x - enemy.oldX;
     enemy.vy = enemy.y - enemy.oldY;
     enemy.oldX = enemy.x;
     enemy.oldY = enemy.y;
     enemy.gotoAndStop(1);

            if (enemy.x > stage.stageWidth)
            {
                enemy.vx *= _bounce;
                enemy.x = stage.stageWidth;
            }
            if (enemy.x < 0)
            {
                enemy.vx *= _bounce;
                enemy.x = 0;
            }
            if (enemy.y > stage.stageHeight - 35)
            {
                enemy.y = stage.stageHeight - 35;
                enemy.vy *= _bounce;
            }
            if (enemy.y < 0)
            {
                enemy.y = 0;
                enemy.vy *= _bounce; 
              }
            }

function onEnterFrame(event:Event):void
 {
        for (var i:int = 0; i < enemies.length; i++)
        {
        var enemy:Enemy = enemies[i];

        if (player.hitTestObject(enemy))
            {
            if (player.currentFrame == 1 || player.currentFrame == 3)
            {
            health.meter.width--;
            player.nextFrame();
            }
            Collision.block(player, enemy);
            }
            else if (player.currentFrame == 2|| player.currentFrame == 4)
            {
            player.prevFrame();
                }
                break;
                }
            }
function checkCollisionWithEnemies(bullet:MovieClip)
{
  for (var i:int = 0; i < enemies.length; i++)
  {
      var enemy:Enemy = enemies[i];
      if (enemy.hitTestPoint(bullet.x, bullet.y,true))
                   {
                    if (player.char_type == 1)
                     {
                        enemy.meter.width -= 10;
                        enemy.gotoAndStop(2);
                        removeChild(bullet);
                        score +=10;
                        scoreText.text = score.toString();
                         break;
                        }
                        if (player.char_type == 3)
                        {
                            enemy.scaleX += 0.1;
                            enemy.scaleY += 0.1;
                            enemy.meter.width += 20;
                            removeChild(bullet);
                            score +=100;
                            scoreText.text = score.toString();
                            break;
                            }
                             if (enemy.meter.width < 1)
                             {
                        
                         var b:B = new B(); 
                         b.x = enemy.x;
                                            b.y = enemy.y;
                        removeChild(enemy);
                        enemy = null;
                        level ++;
                        enemies.splice(i, 1);
                        i--;
                        trace ("Level" + level);
                        levelText.text = level.toString();          
                        addChild(b);
                        checkCollisionWithPlayer(b);
                     }
function swapProperies(dobj1:DisplayObject, dobj2:DisplayObject):void
          {
            var propertyA:Array=["x","y","width","height","rotation"]
            for(var i:int = 0; i<propertyA.length;i++)
            dobj2[propertyA[i]] = dobj1[propertyA[i]];
            }
function checkCollisionWithPlayer(b:MovieClip)
                   {
                    if (player.hitTestObject(b))
                      Collision.block(player, b);
                    }                   
                }
            }

Hi - I've re-edited the code with less required {s although to be honst, its not that different as you say there is alot of defined if statements in this code that needed to create the functionality of the game till this point. Regarding the functions within functions, I don't see any personally thats probably to do with my level of understanding of AS3 (I've only started learning recently). Like I was saying I before, two enemies are formed, one has collision with player other one doesn't (tempEnemy) and either don't have any bullet detection when fired at.

I look forward to your further input/suggestions but if not I understand as you're more or less stated that I've got alot to learn.

Thanks

Jonesy

Actionscript Code:

package 
{
  import flash.display.MovieClip;
  import flash.events.Event;
  import fl.transitions.Tween;
  import fl.transitions.TweenEvent;
  import fl.transitions.easing.*;
  import flash.display.DisplayObject; 
  import flash.text.*; 

  public class MainShapeShooter11 extends MovieClip
   {
        public var score:int = 0; //Game score
        public var level:Number = 1;
        public var enemies:Array; 

              var bullet:Bullet = new Bullet(bullet_Vx, bullet_Vy, bullet_StartX, bullet_StartY, bullet_type);
        var bullet_StartX:Number;
        var bullet_StartY:Number;
        var bullet_Vx:Number;
        var bullet_Vy:Number;
        var bullet_type:String = "square";
        
        public var scoreLabel:TextField = new TextField();
        public var scoreText:TextField = new TextField();
        public var playerHealth:TextField = new TextField();
        public var levelLabel:TextField = new TextField();
        public var levelText:TextField = new TextField();
        
        public const SCOREBOARD_Y:Number =370;
    
    private var _tweenX:Tween;
    private var _tweenY:Tween;
    private var _randomX:uint;
    private var _randomY:uint;
    private var _friction:Number;
    private var _bounce:Number;
    private var _vx:Number;
    private var _vy:Number;
    
    public var char_type:int; 
    
    public function MainShapeShooter11()
    {
     
      _friction = 0.94;
      _bounce = -0.9;
      char_type = 1;
      level = 1;
      score = 0;
     
      //Select a random stage position
      _randomX = Math.ceil(Math.random() * 400);
      _randomY = Math.ceil(Math.random() * 400);

      //Create Tween objects for the x and y axes
      
        scoreLabel.text = "Score"; 
        scoreText.text ="0";
        playerHealth.text = "Player Health";
        levelLabel.text = "Level:";
        levelText.text ="1";
        
        scoreLabel.y = SCOREBOARD_Y;
        scoreText.y = SCOREBOARD_Y;
        playerHealth.y = SCOREBOARD_Y;
        levelLabel.y = SCOREBOARD_Y;
            levelText.y = SCOREBOARD_Y;
        scoreLabel.x = 5;
        scoreText.x = 50;
        playerHealth.x = 350;
        levelLabel.x = 205;
            levelText.x = 265;
        
        addChild(scoreLabel);
        addChild(scoreText);
        addChild(playerHealth);
        addChild(levelLabel);
        addChild(levelText);
        
      //Add enemy listeners 
    enemies = new Array(); 
    makeEnemies();
        }

public function makeEnemies():void 
{
    for(var i:int = 0; i < 2 + level; i++)
    {
    var tempEnemy:Enemy = new Enemy();
    addChild(tempEnemy);
    enemies.push(tempEnemy);
    tempEnemy.gotoAndStop(1);
     addEventListener(Event.ENTER_FRAME, onEnterFrame);
     tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
     
     _tweenX = new Tween(tempEnemy, "x", Regular.easeInOut, tempEnemy.x, _randomX, 45, false);
     _tweenY = new Tween(tempEnemy, "y", Regular.easeInOut, tempEnemy.y, _randomY, 45, false);
     }
   
function onEnemyMove(event:Event):void
    {
     var enemy:Enemy = Enemy(event.currentTarget);
     enemy.vx = enemy.x - enemy.oldX;
     enemy.vy = enemy.y - enemy.oldY;
     enemy.oldX = enemy.x;
     enemy.oldY = enemy.y;
     enemy.gotoAndStop(1);

            if (enemy.x > stage.stageWidth)
            {
                enemy.vx *= _bounce;
                enemy.x = stage.stageWidth;
            }
            if (enemy.x < 0)
            {
                enemy.vx *= _bounce;
                enemy.x = 0;
            }
            if (enemy.y > stage.stageHeight - 35)
            {
                enemy.y = stage.stageHeight - 35;
                enemy.vy *= _bounce;
            }
            if (enemy.y < 0)
            {
                enemy.y = 0;
                enemy.vy *= _bounce; 
              }
            }

function onEnterFrame(event:Event):void
 {
 checkCollisionWithEnemies(bullet);     

for (var i:int = 0; i < enemies.length; i++)
        {
        var enemy:Enemy = enemies[i];

        if (player.hitTestObject(enemy))
            {
            if (player.currentFrame == 1 || player.currentFrame == 3)
            {
            health.meter.width--;
            player.nextFrame();
            }
            Collision.block(player, enemy);
            }
        else if (player.currentFrame == 2|| player.currentFrame == 4)
            {
            player.prevFrame();
                }
                break;
                }
            }
function checkCollisionWithEnemies(bullet:MovieClip)
{
  for (var i:int = 0; i < enemies.length; i++)
  {
      var enemy:Enemy = enemies[i];
      if (enemy.hitTestPoint(bullet.x, bullet.y,true))
                   {
                    if (player.char_type == 1)
                     {
                        enemy.meter.width -= 10;
                        enemy.gotoAndStop(2);
                        removeChild(bullet);
                        score +=10;
                        scoreText.text = score.toString();
                         break;
                            }
                        if (player.char_type == 3)
                        {
                            enemy.scaleX += 0.1;
                            enemy.scaleY += 0.1;
                            enemy.meter.width += 20;
                            removeChild(bullet);
                            score +=100;
                            scoreText.text = score.toString();
                            break;
                            }
                             if (enemy.meter.width < 1)
                             {
                        
                         var b:B = new B(); 
                                    b.x = enemy.x;
                                            b.y = enemy.y;
                        removeChild(enemy);
                        enemy = null;
                        level ++;
                        enemies.splice(i, 1);
                             i--;
                        trace ("Level" + level);
                        levelText.text = level.toString();          
                        addChild(b);
                        checkCollisionWithPlayer(b);
 }
function swapProperies(dobj1:DisplayObject, dobj2:DisplayObject):void
{
var propertyA:Array=["x","y","width","height","rotation"]
for(var i:int = 0; i<propertyA.length;i++)
dobj2[propertyA[i]] = dobj1[propertyA[i]
}
function checkCollisionWithPlayer(b:MovieClip)
                   {
                    if (player.hitTestObject(b))
                      Collision.block(player, b);
                    }                   
                }
            }

MAKE YOUR CODE LINE UP. Normally, I don't care how someone styles their code, since it doesn't affect how it compiles. But in your case I'm going to hand down the ONE TRUE STYLE from on high. You (specifically you: Captain Jonesy) must format your code according to these principles:

1. A line which begins a block ends in a "{"
2. The line with the "}" to end that block is placed to line up with the line that began that block.
3. The contents of a block shall be consistently indented. By two spaces per level of nesting.

Some examples:

Code:

---

public function something():void{
  //some code here
}

---

Code:

---

if (someCondition){
  //do stuff
}

---

Code:

---

for (var i:int = 0; i < someNumber; i++){
  //loop content
}

---

You can see how the ONE TRUE STYLE applies when these are combined.

Code:

---

public function something():void{
  for (var i:int = 0; i < someNumber; i++){
    if(someCondition){
      //do stuff
    } //end if
  } //end for
} //end function.

---

In the code you just posted, you have defined onEnemyMove, onEnterFrame, checkCollisionWithEnemies, swapProperies [sic], and checkCollisionWithPlayer inside makeEnemies. You have also not closed your class or package.

Ok sure, I'm glad you're placed the law down and someone has told me straight. Going to hate me, but just allow me to relay what you're said and confirm that I understand your points from example of my code:

Code:

---

function onEnterFrame(event:Event):void{ //// { begining of function

for (var i:int = 0; i < enemies.length; i++){ /// beginning of loop
var enemy:Enemy = enemies[i]; /// the contents of loop

if (player.hitTestObject(enemy)){ //// beginning of if statement
if (player.currentFrame == 1 || player.currentFrame == 3){
health.meter.width--; //// contents of statement
player.nextFrame();
}  Collision.block(player, enemy);        //// ends this command above after player and enemy have touched 
}
break; /// end commands above with/for a  "break"
} /// end function

///// two spaces for next function
function checkCollisionWithEnemies(bullet:MovieClip){

---

Am I applying you logic here? Or I am missing the boat here?

You have correctly commented several lines, but you have totally failed to indent them properly (or at all). This is actually an improvement over your previous code, because at least the (non)indentation is consistent.

In addition, you did not mark this if statement:

Code:

---

if (player.currentFrame == 1 || player.currentFrame == 3){

---

And you did not put a line break between its closing "}" and the next line

Code:

---

}  Collision.block(player, enemy);        //// ends this command above after player and enemy have touched

---

The line marked ///end function does not actually end the onEnterFrame function. It ends the for loop, leaving onEnterFrame open when you start defining checkCollisionWithEnemies, so checkCollisionWithEnemies is inside onEnterFrame.

By "indent two spaces" I mean two space characters at the beginning of the line, not two blank lines.

Here is your (incorrect) code above, properly indented:

Code:

---

function onEnterFrame(event:Event):void{ //// { begining of function
  //note how this line is not at the far left side
  for (var i:int = 0; i < enemies.length; i++){ /// beginning of loop
    //and how this line is even further to the right
    var enemy:Enemy = enemies[i]; /// the contents of loop
    if (player.hitTestObject(enemy)){ //// beginning of if statement
      if (player.currentFrame == 1 || player.currentFrame == 3){ //begins another if statement
        health.meter.width--; //// contents of inner if statement
        player.nextFrame();
      } //ends inner if
      Collision.block(player, enemy);        //// ends this command above after player and enemy have touched 
    } //ends outer if
    break; /// end commands above with/for a  "break"
  } /// end for-loop

//note that there is no "}" to end the function here, and there should be.

  //this is now indented because you failed to close onEnterFrame, so this is inside it.
  function checkCollisionWithEnemies(bullet:MovieClip){

---

Ok, understand your points regarding the last } indentation for ending the function and the two spaces for new functions but I'm not certain by what you mean by "mark if statement"?

Quote:

---

In addition, you did not mark this if statement:

Code:
if (player.currentFrame == 1 || player.currentFrame == 3){

---

Do you mean it doesn't need to be closed off with { on both ends of the line - beginning and end? Also with the link break are you saying it placed before the Collision.block line?

A

Quote:

---

nd you did not put a line break between its closing "}" and the next line

Code:
} Collision.block(player, enemy); //// ends this command above after player and enemy have

---

Sorry to be pain, just trying to get this nailed down.

Jonesy

I was only referring to the fact that you put comments on all the other block opening lines, but missed that one. There is no need to mark or comment block opening lines, stylistically.

On the Collision.block line, you have the "}" which closed the inner if statement at the beginning, then you put Collision.block on the same line. Although this is valid code and I did not explicitly say not to do that, it is a little visually confusing. Collision.block has nothing to do with the closing "}" on that line, so it shouldn't be on the same line. The only time you should have } followed by more code on the same line is in an if-else situation:

Code:

---

if (someCondition){
  doStuff();
}else{
  doOtherStuff();
}

---

Edit: you can also have "}" with more code in the case of object literals and anonymous functions passed as arguments:

Code:

---

doStuffWithAnObject({propertyOne:1, propertyTwo:2});

doStuffWithAFunction(function():void{
                      trace("blah");
                    });

---

The anonymous function case is admittedly a little weird. You won't have to worry about that until you start doing much more advanced stuff.

Thats handy to know for future reference. You're right regarding the indentation, I've gone through my code again with your advice and its a big improvement, (there's shouldn't be any missing {s) thanks again:)

Here is the current code, the bullet detection is working now but the game spawns 3 enemies and the loop for the makeEnemies function only functions once so therefore when I kill the enemies, no new enemies get created. Any ideas?

Actionscript Code:

package 
{
  import flash.display.MovieClip;
  import flash.events.Event;
  import fl.transitions.Tween;
  import fl.transitions.TweenEvent;
  import fl.transitions.easing.*;
  import flash.display.DisplayObject; 
  import flash.text.*; 

  public class MainShapeShooter11 extends MovieClip
   {
        public var score:int = 0; //Game score
        public var level:int = 1;
        public var enemies:Array; 
        
        var bullet:Bullet = new Bullet(bullet_Vx, bullet_Vy, bullet_StartX, bullet_StartY, bullet_type);
        var bullet_StartX:Number;
        var bullet_StartY:Number;
        var bullet_Vx:Number;
        var bullet_Vy:Number;
        var bullet_type:String = "square";
        
        public var scoreLabel:TextField = new TextField();
        public var scoreText:TextField = new TextField();
        public var playerHealth:TextField = new TextField();
        public var levelLabel:TextField = new TextField();
        public var levelText:TextField = new TextField();
        
        public const SCOREBOARD_Y:Number =370;
    
    private var _tweenX:Tween;
    private var _tweenY:Tween;
    private var _randomX:uint;
    private var _randomY:uint;
    private var _friction:Number;
    private var _bounce:Number;
    private var _vx:Number;
    private var _vy:Number;
    
    public var char_type:int; 
    
    public function MainShapeShooter11()
    {
     
      _friction = 0.94;
      _bounce = -0.9;
      char_type = 1;
      level = 1;
      score = 0;
     
      //Select a random stage position
      _randomX = Math.ceil(Math.random() * 400);
      _randomY = Math.ceil(Math.random() * 400);

      //Create Tween objects for the x and y axes
      
        scoreLabel.text = "Score"; 
        scoreText.text ="0";
        playerHealth.text = "Player Health";
        levelLabel.text = "Level:";
        levelText.text ="1";
        
        scoreLabel.y = SCOREBOARD_Y;
        scoreText.y = SCOREBOARD_Y;
        playerHealth.y = SCOREBOARD_Y;
        levelLabel.y = SCOREBOARD_Y;
        levelText.y = SCOREBOARD_Y;
        scoreLabel.x = 5;
        scoreText.x = 50;
        playerHealth.x = 350;
        levelLabel.x = 205;
        levelText.x = 265;
        
        addChild(scoreLabel);
        addChild(scoreText);
        addChild(playerHealth);
        addChild(levelLabel);
        addChild(levelText);
        
      //Add enemy listeners 
    enemies = new Array(); 
    makeEnemies();
        }
   
  public function makeEnemies():void{
   for(var i:int = 0; i < 2 + level; i++){
     var tempEnemy:Enemy = new Enemy();
     addChild(tempEnemy);
     enemies.push(tempEnemy);
     tempEnemy.gotoAndStop(1);
     addEventListener(Event.ENTER_FRAME, onEnterFrame);
     tempEnemy.addEventListener(Event.ENTER_FRAME, onEnemyMove);
     
     _tweenX = new Tween(tempEnemy, "x", Regular.easeInOut, tempEnemy.x, _randomX, 45, false);
     _tweenY = new Tween(tempEnemy, "y", Regular.easeInOut, tempEnemy.y, _randomY, 45, false);
     }
    }
 
 function onEnemyMove(event:Event):void{
     var enemy:Enemy = Enemy(event.currentTarget);
     enemy.vx = enemy.x - enemy.oldX;
     enemy.vy = enemy.y - enemy.oldY;
     enemy.oldX = enemy.x;
     enemy.oldY = enemy.y;
     enemy.gotoAndStop(1);

    if (enemy.x > stage.stageWidth){
         enemy.vx *= _bounce;
         enemy.x = stage.stageWidth;}
    if (enemy.x < 0){
         enemy.vx *= _bounce;
         enemy.x = 0;}
    if (enemy.y > stage.stageHeight - 35){
         enemy.y = stage.stageHeight - 35;
         enemy.vy *= _bounce;}
    if (enemy.y < 0){
         enemy.y = 0;
         enemy.vy *= _bounce;}
}

  function onEnterFrame(event:Event):void{
  var enemy:Enemy = enemies[i]; 
  for (var i:int = 0; i < enemies.length; i++){   
    if (player.hitTestObject(enemy)){
        if (player.currentFrame == 1 || player.currentFrame == 3){
    health.meter.width--;
    player.nextFrame();
}
Collision.block(player, enemy);         
}
else if (player.currentFrame == 2|| player.currentFrame == 4){
    player.prevFrame();
}
Collision.block(player, enemy);
break;}
}
 function checkCollisionWithEnemies(bullet:MovieClip){
  
  for (var i:int = 0; i < enemies.length; i++){
      var enemy:Enemy = enemies[i];{
      if (enemy.hitTestPoint(bullet.x, bullet.y,true)){
         if (player.char_type == 1){
            enemy.meter.width -= 10;
            enemy.gotoAndStop(2);
            removeChild(bullet);
            score +=10;
            scoreText.text = score.toString();
            break;}
  }else{
   enemy.gotoAndStop(1);}
 if (enemy.hitTestPoint(bullet.x, bullet.y,true)){
    if (player.char_type == 3){
        enemy.scaleX += 0.1;
        enemy.scaleY += 0.1;
        enemy.meter.width += 20;
        removeChild(bullet);
        score +=100;
        scoreText.text = score.toString();}
        break;}
      }
    if (enemy.meter.width < 1){
                        
    var b:B = new B(); 
    b.x = enemy.x;
    b.y = enemy.y;
                        
    swapProperies(enemy,b);
    removeChild(enemy);
    enemy = null;
    level ++;
    enemies.splice(i, 1);
    i--;
    trace ("Level" + level);
    levelText.text = level.toString();          
    addChild(b);
    checkCollisionWithPlayer(b);}
}
  function swapProperies(dobj1:DisplayObject, dobj2:DisplayObject):void{
            var propertyA:Array=["x","y","width","height","rotation"]
            for(var i:int = 0; i<propertyA.length;i++)
            dobj2[propertyA[i]] = dobj1[propertyA[i]];}
}
  function checkCollisionWithPlayer(b:MovieClip){
    if (player.hitTestObject(b)){
        Collision.block(player, b);
                    }                   
                }
            }
        }

When do you want more enemies? Call makeEnemies again then. For instance, you could call makeEnemies again when you kill off the last enemy (which you could detect by the length of the enemies array after you remove that enemy).

Oh yeah of course, good point :) Thank you very much for your all help, you're been very helpful 5TonsOfFlax, good one!