[HELP] Score code in the main layer?

[CrazY.]

Hey everbody

I try make a code to work with all coins existing in the game, but not work correctly. I inserted the code in the first layer of the timeline. The code is this:

coin.onEnterFrame = function()
{
	if (_root.player_mc.hitTest(this))
	{
		score += 1;
		unloadMovie(this);
	}
}

The problem is this: when I picked up a coin, works only time I try to pick up the second currency, the code does not work. How can I fix this? Thank you anyway

[CrazY.]

Sorry for the spam.

See the problem here (do not forget to click on the game to work): http://www.fastswf.com/xbianPQ

[realMakc]

the code is correct, but you have to do it for *every* coin. just pasting the code above will only work for one of them. you could put this into the coin mc, doing this.onEnterFrame = ..., instead.

[CrazY.]

Hey man.. I've done it.. but somehow.. do not "corrupt" game? For example, start getting lag in the game?

[realMakc]

yes, of course, because hit test is expensive operation. now you're looking into optimizing this, for example running the test only if the coin is visible on the screen, or within 100 pixels from the hero

[CrazY.]

Nice! Any idea about how to make this? Example code or a link? c.c

[realMakc]

assuming coins are also in the _root, try changing

if (_root.player_mc.hitTest(this)) 

to

if ((Math.abs(_root.player_mc._x - this._x) < 100) && _root.player_mc.hitTest(this)) 

[realMakc]

oh, another idea is that as2 might be upset by the number of onEnterFrame handlers this creates. so, if the above hitTest guess is not correct, try creating onEnterFrame on player instead and loop over coins there.

[CrazY.]

Nice code man, if I want that this code also works with y, just replace the x or need to make any more changes?

The other idea is awesome, I will test it.

[CrazY.]

Hey... sorry for the resurrected the topic, but I was still having trouble about it. I've searched various forms of loop the coins but found nothing. Anyone has any idea?

[realMakc]

sure, here is how to loop